Fixing random JSDoc issues #6392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Will Eastcott <willeastcott@gmail.com>
…llow an optional parameter.
willeastcott
approved these changes
May 17, 2024
slimbuck
pushed a commit
to slimbuck/engine
that referenced
this pull request
May 20, 2024
* Fixing random JSDoc issues that cause spam or other issues in RTI.js logs * Update src/scene/skin-instance.js Co-authored-by: Will Eastcott <willeastcott@gmail.com> * src/scene/skin-instance.js: add @ignore * ForwardRenderer fix for: error TS1016: A required parameter cannot follow an optional parameter. --------- Co-authored-by: Will Eastcott <willeastcott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main reason is they are causing type error spam every frame in Examples browser or other issues in RTI.js, e.g. the broken Vec4 import.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.