Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last direct mentions of GL1 #6398

Merged
merged 3 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ PlayCanvas is used by leading companies in video games, advertising and visualiz

PlayCanvas is a fully-featured game engine.

* 🧊 **Graphics** - Advanced 2D + 3D graphics engine built on WebGL 1 & 2.
* 🧊 **Graphics** - Advanced 2D + 3D graphics engine built on WebGL2 & WebGPU.
* 🏃 **Animation** - Powerful state-based animations for characters and arbitrary scene properties
* ⚛️ **Physics** - Full integration with 3D rigid-body physics engine [ammo.js](https://github.com/kripken/ammo.js)
* 🎮 **Input** - Mouse, keyboard, touch, gamepad and VR controller APIs
Expand Down
2 changes: 1 addition & 1 deletion src/platform/graphics/webgl/webgl-graphics-device.js
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ class WebglGraphicsDevice extends GraphicsDevice {
this.extCompressedTextureASTC = this.getExtension('WEBGL_compressed_texture_astc');
this.extParallelShaderCompile = this.getExtension('KHR_parallel_shader_compile');

// iOS exposes this for half precision render targets on both Webgl1 and 2 from iOS v 14.5beta
// iOS exposes this for half precision render targets on WebGL2 from iOS v 14.5beta
this.extColorBufferHalfFloat = this.getExtension("EXT_color_buffer_half_float");
}

Expand Down
1 change: 0 additions & 1 deletion src/scene/gsplat/gsplat-instance.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ class GSplatInstance {
// clone options object
options = Object.assign(this.options, options);

// not supported on WebGL1
const device = splat.device;

// create the order texture
Expand Down
2 changes: 1 addition & 1 deletion src/scene/renderer/shadow-map.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class ShadowMap {

static createCubemap(device, size, shadowType) {

const format = (shadowType === SHADOW_PCSS && !device.isWebGL1) ? PIXELFORMAT_R32F : PIXELFORMAT_RGBA8;
const format = shadowType === SHADOW_PCSS ? PIXELFORMAT_R32F : PIXELFORMAT_RGBA8;
const cubemap = new Texture(device, {
// #if _PROFILER
profilerHint: TEXHINT_SHADOWMAP,
Expand Down
2 changes: 1 addition & 1 deletion src/scene/shader-lib/programs/lit-shader.js
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ class LitShader {
if (shadowTypeUsed[SHADOW_PCF1] || shadowTypeUsed[SHADOW_PCF3]) {
func.append(chunks.shadowStandardPS);
}
if (shadowTypeUsed[SHADOW_PCF5] && !device.isWebGL1) {
if (shadowTypeUsed[SHADOW_PCF5]) {
func.append(chunks.shadowStandardGL2PS);
}
if (useVsm) {
Expand Down