Fix URL handling in ScriptHandler #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpal81xd
approved these changes
May 28, 2024
marklundin
added a commit
that referenced
this pull request
May 31, 2024
marklundin
added a commit
that referenced
this pull request
Jun 4, 2024
marklundin
added a commit
that referenced
this pull request
Jun 4, 2024
mvaligursky
pushed a commit
that referenced
this pull request
Jun 5, 2024
marklundin
added a commit
that referenced
this pull request
Jun 18, 2024
* refactored script type * removed attribute check on esm scripts * linting fixes * Delete redundant scripts * Remove engines field from package-lock.json * Fix event name in ScriptType class * Add export to rawToValue function and update script schema in ScriptHandler * linting * Update script attribute assignment in ScriptComponent * Fix script initialization and enablement * Fix missing semicolon in ScriptRegistry class * Refactor script component and handler * GS reorder fix (#6410) * USDZ / GLTF exporter supports exposing of compressed textures on WebGPU (#6394) * Support for Picker on WebGPU * Gizmos example on webgpu * USDZ / GLTF exporter supports exposing of compressed textures on WebGPU * tiny comment update --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * restore default color when setting axis shape disable to false (#6587) * [Fix] Add missing exposure handling from the Neutral tonemapping (#6592) * SSAO engine example (#6586) * SSAO engine example * lint * draco + texture resize: 17MB -> 6MB --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * [BREAKING] Removed backwards compatibility for few functions (#6408) * [BREAKING] Removed backwards compatibility for few functions * lint --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Examples app bundle optimizations (#6588) * treeshake smallest enabled * ignore playcanvas PCUI from being treeshaken * treeshake ignore only pcui * added device type constants directly (no playcanvas dependency) * format rollup * word wrap fix * Updated PCUI * removed PCUI aliasing * Fix to just submitted AO example to disabled baked in occlusion maps (#6593) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * added publint to ci; removed build:publish (#6363) * Fix types for calcAabb functions (#6596) * vercel setup (#6600) * replaces slashes for windows (#6601) * fixed using query params with iframe example (#6604) * New texture formats: R8 and RG8 (#6602) * New texture formats: R8 and RG8 * Apply suggestions from code review Co-authored-by: Will Eastcott <will@playcanvas.com> * deprecate the old constants --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> Co-authored-by: Will Eastcott <will@playcanvas.com> * Added orthogonal facing translation to gizmo (#6607) * set shader chunk type to record (#6621) * Gizmo example update (#6622) * separated out grid code * split out selector and disabled deselection on orbiting * added type for observer set callback * fixed example page * Exports and types fixes (#6623) * cleaned up ts and js config; adds debug and profiler to exports * set module resolution to node * added package json for linting of example modules and renamed @examples to examples * PR commit (#6626) * fixed fallback options (#6628) * fixed example types (#6634) * fixed selection bug (#6637) * Fix URL handling in ScriptHandler (#6639) * Fix mesh collider creation (#6630) * Docs update (#6631) * docs update * Update README.md --------- Co-authored-by: Will Eastcott <willeastcott@gmail.com> * Update script component to use getSchema method instead of tSchema * Refactor script component attribute initialization * merge fix * linting * Update import statement in script.js * Refactor script attribute assignment * linting * Refactor script component initialization * Refactor script component and script handler * linting + comments * Fix the definition of sheenTint Standard Material property (#6665) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Update to skybox shader to map it closer to the infinity (#6664) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * [Fix] Particle system handle different IB formats of incoming mesh (#6662) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * [BREAKING] Remove deprecated AudioSourceComponent component (#6407) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Cubemap fix for webgpu (#6669) * [BREAKING] Remove support for legacy scripts (#6584) * [BREAKING] Remove support for legaxy scripts * removed pc.script.attribute --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Fix shader chunk error for tonemapped compressed GS (#6670) * Remove support for legacy scripts * Remove legacy script system * Add getScriptName function and toLowerCamelCase utility function * jsdoc improvements * Update src/framework/script/script.js Co-authored-by: Will Eastcott <will@playcanvas.com> * Update src/framework/script/script-attributes.js Co-authored-by: Will Eastcott <will@playcanvas.com> * linting + feedback * Update src/framework/script/script.js Co-authored-by: Will Eastcott <will@playcanvas.com> * removed redundant error link * Update src/framework/script/script.js Co-authored-by: Will Eastcott <will@playcanvas.com> * Update src/framework/script/script.js Co-authored-by: Will Eastcott <will@playcanvas.com> * Update src/framework/script/script.js Co-authored-by: Will Eastcott <will@playcanvas.com> * Update src/framework/script/script-attributes.js Co-authored-by: Will Eastcott <will@playcanvas.com> * Update src/framework/script/script-type.js Co-authored-by: Will Eastcott <will@playcanvas.com> * Update src/framework/components/script/component.js Co-authored-by: Will Eastcott <will@playcanvas.com> * Refactor attributeToValue function --------- Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com> Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> Co-authored-by: KPal <48248865+kpal81xd@users.noreply.github.com> Co-authored-by: Will Eastcott <will@playcanvas.com> Co-authored-by: kpal81xd <kpal81xd@gmail.com> Co-authored-by: Alex <LeXXik@users.noreply.github.com> Co-authored-by: Will Eastcott <willeastcott@gmail.com>
MAG-AdrianMeredith
added a commit
to magnopus/playcanvas-engine
that referenced
this pull request
Aug 6, 2024
* Branch 1.71 * GS reorder fix (playcanvas#6409) * Gsplat rendering fix (playcanvas#6590) * [Fix] Add missing exposure handling from the Neutral tonemapping (playcanvas#6592) * Examples app bundle v1 (playcanvas#6594) * treeshake smallest enabled * ignore playcanvas PCUI from being treeshaken * treeshake ignore only pcui * added device type constants directly (no playcanvas dependency) * format rollup * Updated PCUI * removed PCUI aliasing * added publint to ci; removed build:publish (playcanvas#6595) * replaces slashes for windows (playcanvas#6603) * fixed using query params with iframe example (playcanvas#6605) * Fix types for calcAabb functions (playcanvas#6596) * Exports and types fixes v1 (playcanvas#6624) * cleaned up ts and js config; adds debug and profiler to exports * set module resolution to node * Examples config fixes v1 (playcanvas#6627) * added package json for linting of example modules and renamed @examples to examples * fixed missing merge conflict * fixed fallback options (playcanvas#6629) * fixed example types (playcanvas#6635) * adjusted publint error * Fix URL handling in ScriptHandler (playcanvas#6639) (playcanvas#6655) * Particle system uses uint16 indices instead of uint32 (playcanvas#6661) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Fix the definition of sheenTint Standard Material property (playcanvas#6665) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Update to skybox shader to map it closer to the infinity (playcanvas#6664) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Fix shader chunk error for tonemapped compressed GS (playcanvas#6670) * Cherry picked: Add JSDoc for getters (playcanvas#6685) * Gsplat fixes (playcanvas#6710) * GSplat reorder and shader speedup (playcanvas#6715) (playcanvas#6716) * Update setFromMat4 and add tests (playcanvas#6720) * Do not compile different shader for opacity of 1 and diffuse tint of white (playcanvas#6721) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Compressed splat update (playcanvas#6746) * Unify gsplat shaders (playcanvas#6753) * Branch 1.72 * Fix gsplat example (playcanvas#6754) * Improve some JSDoc class descriptions (playcanvas#6725) * Improve some JSDoc class descriptions * Lint fixes * Improve GSplatComponent * Remove redundant debugRender from GSplat examples * Improve the Color class description * Leverage WebXR types in public API (playcanvas#6713) * Improve typings and docs for XrPlane (playcanvas#6708) * Improve typing for XrPlane#points * Tweak docs for XrPlane#label * Improve class description * Improve orientation docs * Tweak example source * Correct XrTrackedImage construction docs * Tighten type for XrPlane#orientation * Tweaks to XrAnchor source (playcanvas#6706) * Tweaks to XrAnchor source * More minor docs tweaks * Improve forget docs * Invoke stopPropagation on pointer events handled by gizmo (playcanvas#6770) * [Fix] Stencil clearing was not setting up the mask correctly (playcanvas#6778) * Fix WebXR depth sensing on quest 3 (playcanvas#6774) * Update Tags class to use spread instead of arguments (playcanvas#6775) * Use object destructuring with vectors (playcanvas#6777) * Minor refactor of Curve class (playcanvas#6780) * Minor refactor of Curve class * Tweaks to docs * Gizmo event fix (playcanvas#6790) * Small gizmo event handler fix (playcanvas#6811) * Support for OffscreenCanvas in Web Workers (playcanvas#5167) * Support for OffscreenCanvas in Web Workers playcanvas#2481 * Update graphics-device.js * Update platform.js --------- Co-authored-by: Will Eastcott <willeastcott@gmail.com> * Add gsplat mapping (playcanvas#6824) * array length fix * Branch 1.73 * v1.73.0 * [Fix] Fix albedo debug output (playcanvas#6836) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> * Fix gsplat sorting bug (playcanvas#6845) * v1.73.1 * Small fix to gsplat sorter (playcanvas#6846) * Allow blit to backbuffer (playcanvas#6849) * always assign animation assets to anim component (playcanvas#6863) * getAnimationAsset returns Asset (playcanvas#6864) * fixed getAnimationAsset return to be asset * reverts change as breaking and updates type to match * Update src/framework/components/anim/component-layer.js Co-authored-by: Will Eastcott <will@playcanvas.com> * Update src/framework/components/anim/component-layer.js Co-authored-by: Will Eastcott <will@playcanvas.com> --------- Co-authored-by: Will Eastcott <will@playcanvas.com> * 1.73.2 * v1.73.3 * v1.73.4 * Support for EXT_mesh_gpu_instancing extension (playcanvas#6869) Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> --------- Co-authored-by: Donovan Hutchence <slimbuck7@gmail.com> Co-authored-by: Martin Valigursky <59932779+mvaligursky@users.noreply.github.com> Co-authored-by: KPal <48248865+kpal81xd@users.noreply.github.com> Co-authored-by: Will Eastcott <will@playcanvas.com> Co-authored-by: kpal <kpal81xd@gmail.com> Co-authored-by: Mark Lundin <marklundin@users.noreply.github.com> Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> Co-authored-by: mrmaxm <core@moka.co> Co-authored-by: Michael Franzl <michael@franzl.name> Co-authored-by: Will Eastcott <willeastcott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the URL handling in ScriptHandler for ESM Scripts when projects are not served from the root.
Partially solves #6638