Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi app fix #6645

Merged
merged 2 commits into from
May 31, 2024
Merged

Multi app fix #6645

merged 2 commits into from
May 31, 2024

Conversation

kpal81xd
Copy link
Contributor

Fixes #6388
Fixes #6309

  • Wraps add app in async function so can await on app creation
  • Passed in application when creating entity (See below for explanation)

The application passed into the entity is used to register new component systems of which one is the CameraComponent. The camera component's layers are then used to construct the render passes. If there is an existing application the current application reference will be set to the first application every update frame. Therefore if you construct a new application without starting it and create a new entity it will use the first application reference and in turn render using its graphics device in turn.

@kpal81xd kpal81xd self-assigned this May 30, 2024
@kpal81xd kpal81xd added area: graphics Graphics related issue area: examples labels May 30, 2024
@kpal81xd kpal81xd requested a review from a team May 30, 2024 17:08
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this fixed! 👏

@kpal81xd kpal81xd merged commit 1ebe3d1 into main May 31, 2024
8 checks passed
@kpal81xd kpal81xd deleted the multi-app-fix branch May 31, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples area: graphics Graphics related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question on multi-app MultiApp Example hot reload WebGL2 not rendering
2 participants