Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderPass based SSAO #6657

Merged
merged 2 commits into from
Jun 6, 2024
Merged

RenderPass based SSAO #6657

merged 2 commits into from
Jun 6, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 4, 2024

  • implementation of SSAO using render passes
  • few small improvements compared to the implementation using the post-effects (increasing number of samples does not modify the brightness, exposed additional controls ..)

no SSAO
Screenshot 2024-06-04 at 16 28 04

un-blured SSAO
Screenshot 2024-06-04 at 16 28 14

blurred SSAO
Screenshot 2024-06-04 at 16 28 23

@mvaligursky mvaligursky self-assigned this Jun 4, 2024
@mvaligursky mvaligursky requested a review from a team June 4, 2024 15:32
@mvaligursky mvaligursky added feature area: graphics Graphics related issue labels Jun 4, 2024
@Maksims
Copy link
Collaborator

Maksims commented Jun 4, 2024

minAngle does not seem to do anything?

@mvaligursky
Copy link
Contributor Author

mvaligursky commented Jun 5, 2024

minAngle does not seem to do anything?

hey, last minute change for it to work as a preset. Fixed now, thanks @Maksims
It avoids ambient occlusion by low tessellated geometry - visible on the inside of the curve as those polygons create occlusion lines:

Screenshot 2024-06-05 at 16 31 46

but it's also used to avoid occlusion when scaling is used.

@mvaligursky mvaligursky merged commit 9868aa6 into main Jun 6, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-ssao-render-passes branch June 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants