-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESM example #6735
ESM example #6735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I assume this Rotator script when dropped to the Editor will work without any changes needed?
|
||
class Rotator extends Script { | ||
/** | ||
* @attribute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will be a lot of linting fun when people start using @assetType
instead of @type {Asset<SomeType>}
too 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I think we decided on @resource
over @assetType
in the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I know, we gotta whitelist those new tags now to prevent lint errors?
Like @attribute
and @resourcetype
or whatever the decisions are so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have Monaco support for this, we need to see how this works in vscode
Yes it should do. |
the |
Yea its to do with the path resolution for import inside blobs being different |
fileImport
util method for importing files outside blob contextRotator
script