Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant StandardMaterial.shadingModel #6757

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Remove redundant StandardMaterial.shadingModel #6757

merged 1 commit into from
Jun 27, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jun 27, 2024 •
edited
Loading

  • Now that the Phong model has been removed, this parameter is hardcoded to BlinnPhong and that is never used during the shader generation or elsewhere, and so can be safely removed.
  • SPECULAR_BLINN is also removed

@mvaligursky mvaligursky self-assigned this Jun 27, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Jun 27, 2024
@mvaligursky mvaligursky requested a review from a team June 27, 2024 11:50
@mvaligursky mvaligursky merged commit 4cac923 into main Jun 27, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-remove-shading-model branch June 27, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck