Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AppBase#preload #6788

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Refactor AppBase#preload #6788

merged 1 commit into from
Jul 8, 2024

Conversation

willeastcott
Copy link
Contributor

Dump unnecessary Progress class and simplify preloading (load and error callbacks are identical for example).

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer

Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golly so much better <3

@willeastcott willeastcott merged commit 3c568b2 into main Jul 8, 2024
8 checks passed
@willeastcott willeastcott deleted the refactor-preload branch July 8, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants