Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated uniform for grab pass textures: uDepthMap and texture_grabPass #6796

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Remove deprecated uniform for grab pass textures: uDepthMap and texture_grabPass #6796

merged 2 commits into from
Jul 9, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 9, 2024 •
edited
Loading

  • if the old names are still used by the user shaders, the engine asserts and prints instructions on what name to use instead.

@mvaligursky mvaligursky self-assigned this Jul 9, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Jul 9, 2024
@mvaligursky mvaligursky requested a review from a team July 9, 2024 14:31
@mvaligursky mvaligursky merged commit 18aee53 into main Jul 9, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-remove-grabpass-uniforms branch July 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @willeastcott @slimbuck