Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Remove StandardMaterial.sheenTint #6809

Merged
merged 2 commits into from
Jul 11, 2024
Merged

[BREAKING] Remove StandardMaterial.sheenTint #6809

merged 2 commits into from
Jul 11, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 11, 2024 •
edited
Loading

Removed the material property sheenTint, and it's assumed to be always true:

  • it used to default to white color, and so it has no effect with the multiply unless the color has been changed.
  • this is breaking in only a small number of cases, where sheen color has been changed, but sheenTint left as false
  • we'll handle the correction inside the Editor projects

@mvaligursky mvaligursky mentioned this pull request Jul 11, 2024
Closed
22 tasks
@mvaligursky mvaligursky self-assigned this Jul 11, 2024
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Jul 11, 2024
@mvaligursky mvaligursky requested a review from a team July 11, 2024 13:56
Merge branch 'main' into mv-remove-sheentint
012aecc 
# Conflicts:
#	src/scene/materials/standard-material.js
@mvaligursky mvaligursky merged commit 5094173 into main Jul 11, 2024
7 of 8 checks passed
@mvaligursky mvaligursky deleted the mv-remove-sheentint branch July 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck