Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug error removeComponent correct method name #6848

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Debug error removeComponent correct method name #6848

merged 4 commits into from
Aug 5, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Jul 24, 2024 •
edited
Loading

Correct Debug error method name for removeComponent

@kpal81xd kpal81xd self-assigned this Jul 24, 2024
@kpal81xd kpal81xd added the bug label Jul 24, 2024
@kpal81xd kpal81xd requested a review from a team July 24, 2024 14:14
@mvaligursky
Copy link
Contributor

We already have an error in the entity constructor that should trigger when entity does not have the app

@kpal81xd
Copy link
Contributor Author

We already have an error in the entity constructor that should trigger when entity does not have the app

Ahh okay this should throw an error however not just a Debug.assert. It gets stripped out of debug build so will silently fail until you attempt to add a component

@kpal81xd kpal81xd changed the title Entity addComponent/removeComponent error handling Handling undefined app in entity Jul 24, 2024
@kpal81xd kpal81xd changed the title Handling undefined app in entity Handling undefined app in Entity Jul 24, 2024
@kpal81xd kpal81xd changed the title Handling undefined app in Entity Debug error removeComponent correct method name Jul 30, 2024
@kpal81xd kpal81xd requested a review from mvaligursky July 30, 2024 11:20
@kpal81xd kpal81xd merged commit 426c4f1 into main Aug 5, 2024
8 checks passed
@kpal81xd kpal81xd deleted the entity-component-fix branch August 5, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpal81xd @mvaligursky @willeastcott