Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Remove no longer needed drawTexture #6886

Merged
merged 3 commits into from
Aug 19, 2024
Merged

[BREAKING] Remove no longer needed drawTexture #6886

merged 3 commits into from
Aug 19, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Aug 19, 2024 •
edited
Loading

  • removed global WebGL only drawTexture call that was public. It was used by the post-effects only, and that has been replaced a long time ago.
  • marking as BREAKING in case somebody was using this function for other purpose. The workaround is to use drawQuadWithShader with a simple shader.

@mvaligursky mvaligursky requested a review from a team August 19, 2024 14:41
@mvaligursky mvaligursky self-assigned this Aug 19, 2024
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Aug 19, 2024
@mvaligursky mvaligursky mentioned this pull request Aug 19, 2024
Closed
22 tasks
@mvaligursky mvaligursky merged commit 1e0b197 into main Aug 19, 2024
7 of 8 checks passed
@mvaligursky mvaligursky deleted the mv-remove-drawTexture branch August 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck