Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix to lightmapping not baking shadows on the following runs #7022

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[Fix] Fix to lightmapping not baking shadows on the following runs #7022

merged 1 commit into from
Oct 10, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Oct 10, 2024 •
edited
Loading

Fixes #7016

  • store the actual internal flag, and not a derived flag handled by the getter. This allows shadow property to be restored correctly.

@mvaligursky mvaligursky changed the base branch from main to main_v1 October 10, 2024 09:48
@mvaligursky mvaligursky self-assigned this Oct 10, 2024
@mvaligursky mvaligursky added bug area: graphics Graphics related issue labels Oct 10, 2024
@mvaligursky mvaligursky merged commit 79800b4 into main_v1 Oct 10, 2024
1 check was pending
@mvaligursky mvaligursky deleted the mv-lightmapping-flag branch October 10, 2024 09:57
mvaligursky added a commit that referenced this pull request Oct 10, 2024
@mvaligursky
[Fix] Fix to lightmapping not baking shadows on the following runs (#…
e3d6eea 
…7022)

Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck