Combine render passes where feasible #7040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
added
performance
willeastcott
approved these changes
Oct 15, 2024
LeXXik
reviewed
Oct 15, 2024
|
|
||
| // if the render targets are different, we can't merge the passes | ||
| // also only merge passes that have a render target | ||
| if (firstRT !== secondRT || firstRT === undefined) { |
There was a problem hiding this comment.
nope, a NULL is valid case, just not undefined. null means rendering to backbuffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization: when two (or more) following render passes render to the same render target + few other conditions are met, render them in a single pass. This is an optimization for tiled architecture (mostly mobile), to avoid the first pass having to write out the render target to main memory and then load it back in the following pass, keeping it all in the fast tile memory.
Typically a UI rendering is merged into RenderPassCompose (post-processing). We save the color buffer + depth buffer store and then load, which is costly especially when MSAA is used.
