Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gizmo clipping plane fix #7045

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Gizmo clipping plane fix #7045

merged 4 commits into from
Oct 17, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Oct 16, 2024

Fixes gizmo clipping by the camera

Here you can see the gizmo has not been clipped but the grid lines have:

image

@kpal81xd kpal81xd self-assigned this Oct 16, 2024
@kpal81xd kpal81xd requested review from a team and slimbuck October 16, 2024 16:27
@kpal81xd kpal81xd added the bug label Oct 16, 2024
@kpal81xd kpal81xd merged commit c2559ea into main Oct 17, 2024
7 of 8 checks passed
@kpal81xd kpal81xd deleted the gizmo-fixes branch October 17, 2024 13:26
kpal81xd added a commit that referenced this pull request Oct 17, 2024
* clamped z to w to prevent clipping

* fixed z clamping issue with cull flag

* Updated get selection to use camera position and screen to world with clip range

* Removed sign from gizmo shader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants