Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gizmo features #7050

Merged
merged 12 commits into from
Oct 21, 2024
Merged

Gizmo features #7050

merged 12 commits into from
Oct 21, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Oct 18, 2024 •
edited
Loading

Fixes #6851

  • The planes for translate and scale gizmos will now orient themselves to be nearest to the camera for easier access
  • The planes are hidden at glancing angles
  • Added option to set lower bound scale lowerBoundScale: Vec3 = new Vec3(-Infinity, -Infinity, -Infinity)
  • Removed unnecessary vec cloning

API Changes

  • Adds new property to enable flipping planes flipPlanes: boolean = true

Preview

Plane orientation
image
image

Plane hiding
image

@kpal81xd kpal81xd self-assigned this Oct 18, 2024
@kpal81xd kpal81xd requested review from a team and slimbuck October 18, 2024 14:37
@kpal81xd kpal81xd changed the title Gizmo planes flip to face camera Gizmo features Oct 18, 2024
@kpal81xd kpal81xd merged commit f07d970 into main Oct 21, 2024
8 checks passed
@kpal81xd kpal81xd deleted the gizmo branch October 21, 2024 12:25
kpal81xd added a commit that referenced this pull request Oct 21, 2024
@kpal81xd
Gizmo features (#7050)
c2993f3 
* WIP: plane flip for translate gizmo

* Fixed plane flipping for any rotation and added to scale and translate

* Added update epsilon for plane flip

* changed update transform to just update position

* Add setting to enable flipping planes

* Added gizmo glancing angle hide

* Removed trailing spaces

* changed updates to prerender

* Added lower scale bound

* removed vector clones and resused tmp vectors

* Renamed scale lower bound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@kpal81xd kpal81xd

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gizmo translate/scale plane orientation
2 participants
@kpal81xd @slimbuck