Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gsplat shader chunk updates #7169

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Gsplat shader chunk updates #7169

merged 3 commits into from
Dec 4, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Dec 4, 2024

This PR is a followup to #7164. The following shader changes are made:

  • bugfix for blurry gaussians when viewport isn't square
  • split readCenter into two functions, initState and readCenter (allows early-out optimisation in SuperSplat)
  • directly support ortho camera (also required for SuperSplat)
  • spherical harmonic eval optimisations

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Dec 4, 2024
@slimbuck slimbuck requested a review from a team December 4, 2024 11:01
@slimbuck slimbuck self-assigned this Dec 4, 2024
@slimbuck slimbuck merged commit 3e6c6d5 into playcanvas:main Dec 4, 2024
8 checks passed
@slimbuck slimbuck deleted the gsplat-shader-dev branch December 4, 2024 11:33
mvaligursky pushed a commit that referenced this pull request Dec 4, 2024
@slimbuck
Gsplat shader chunk updates (#7169)
1ca043a
@slimbuck slimbuck mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimbuck @willeastcott @mvaligursky