Update to render passes - generate scene half sized texture #7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
reviewed
Dec 6, 2024
willeastcott
approved these changes
Dec 6, 2024
Co-authored-by: Will Eastcott <will@playcanvas.com>
slimbuck
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Update to render passes - generate scene half sized texture * Update src/platform/graphics/render-target.js Co-authored-by: Will Eastcott <will@playcanvas.com> --------- Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com> Co-authored-by: Will Eastcott <will@playcanvas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: The scene gets rendered to a render target. The bloom then blurs it by downscaling and upscaling, starting at half size. The first bloom pass would just cheaply (box filter) downscale to half size. That makes the final bloom texture half size of the scene.
Now: The cheap downscale to half res is pulled out of bloom, as that is something other effects (DOF) needs as well, so lets generate it only one time. Bloom then uses it.
Small change is that the bloom texture ends up being a quarter size and not half size, so slightly cheaper, but I cannot see any difference visually, so happy with this.