Skip to content

Commit

Permalink
Update CONTRIBUTING.md (#433)
Browse files Browse the repository at this point in the history
* Update CONTRIBUTING.md

* Update config.yml
  • Loading branch information
brocollie08 authored Jul 15, 2024
1 parent ab58074 commit 77023dd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ orbs:
executors:
base:
docker:
- image: docker.io/playerui/bazel-docker:10
- image: docker.io/playerui/bazel-docker
working_directory: ~/player
resource_class: xlarge
environment:
Expand Down Expand Up @@ -523,4 +523,4 @@ workflows:
requires:
- android_test
- coverage
- build_ios
- build_ios
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ If the changes are larger (API design, architecture, etc), [opening an issue](ht
* [Swift >= 5.5](https://www.swift.org/download/)
* [Xcode 15.3](https://developer.apple.com/download/all/)

* [Android NDK >= 19.2.5345600, <= 21](https://github.com/android/ndk/wiki/Unsupported-Downloads#r19c). Any version > 21 will not work, period. You'll need to add `ANDROID_NDK_HOME` to your environment manually.
* [Android NDK 23.2.8568313](https://github.com/android/ndk/wiki/Unsupported-Downloads#r23c). You'll need to add `ANDROID_NDK_HOME` to your environment manually.
* Python < 3 (recommended 2.7.18) - you can use [pyenv](https://realpython.com/intro-to-pyenv/) to manage different python versions with ease.

* [Signed Commits](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification). For convenience it is recommended to set git to sign all commits by default as mentioned [here](https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key)
Expand Down

0 comments on commit 77023dd

Please sign in to comment.