Skip to content

Commit

Permalink
more leftovers
Browse files Browse the repository at this point in the history
  • Loading branch information
sugarmanz committed Dec 4, 2023
1 parent ed862a2 commit 934d05b
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public data class AssetContext(
factory: (AssetContext) -> RenderableAsset,
) : this(context, asset, player, factory, asset.id)

@Deprecated("Replacing with `with`-style builder calls", ReplaceWith("withTag(tag)", "com.intuit.player.android.AssetContext.withTag"))
@Deprecated("Replacing with `with`-style builder calls", ReplaceWith("withTag(tag)", "com.intuit.playerui.android.AssetContext.withTag"))
public fun postFixId(tag: String): AssetContext = withTag(tag)

val type: String by lazy {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ public constructor(public val assetContext: AssetContext) : NodeWrapper {

public class Serializer(private val player: AndroidPlayer) : KSerializer<RenderableAsset?> {

override val descriptor: SerialDescriptor = buildClassSerialDescriptor("com.intuit.player.android.asset.RenderableAsset")
override val descriptor: SerialDescriptor = buildClassSerialDescriptor("com.intuit.playerui.android.asset.RenderableAsset")

/** Deserialize using the expansion process */
override fun deserialize(decoder: Decoder): RenderableAsset? = decoder.requireNodeDecoder()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public abstract class PlayerFragment : Fragment(), ManagedPlayerState.Listener {

/**
* [ViewModel][androidx.lifecycle.ViewModel] responsible for managing an [AndroidPlayer]
* with respect to a specific [FlowManager][com.intuit.player.jvm.core.managed.FlowManager].
* with respect to a specific [FlowManager][com.intuit.playerui.core.managed.FlowManager].
*/
public abstract val playerViewModel: PlayerViewModel

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public interface Node : Map<String, Any?> {
@Deprecated(
"Replaced with getInvokable, which requires a deserializer for the return type. Either provide a deserializer explicitly, " +
"or use the extension to automatically determine the correct serializer.",
ReplaceWith("getInvokable<R>(key)", "com.intuit.player.jvm.core.bridge.getInvokable"),
ReplaceWith("getInvokable<R>(key)", "com.intuit.playerui.core.bridge.getInvokable"),
DeprecationLevel.WARNING,
)
public fun <R> getFunction(key: String): Invokable<R>? = get(key).safeCast()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import kotlinx.serialization.Serializable
* However, with the immutable principles implemented by the core player runtime, this means that any mutated value
* is meant to be a completely new object. Persisting an early value would result in an object that is potentially
* _not_ the final accumulated value, meaning it might not even be relevant anymore. In some circumstances, this
* value might be garbage collected and result in a [PlayerRuntimeException][com.intuit.player.jvm.core.bridge.PlayerRuntimeException]
* value might be garbage collected and result in a [PlayerRuntimeException][com.intuit.playerui.core.bridge.PlayerRuntimeException]
* representing that the underlying JS instance has been released. If there is a use case to persist this value
* outside of the tapped function, this can be done by reading the information and storing it in a non-Node backed
* object from within the tapped function.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class NodeSerializer : KSerializer<Node> {
public open class NodeWrapperSerializer<T : NodeWrapper>(
private val factory: (Node) -> T,
// TODO: Can we pull this from the @SerialName annotation?
private val serialName: String = "com.intuit.player.jvm.core.bridge.NodeWrapper",
private val serialName: String = "com.intuit.playerui.core.bridge.NodeWrapper",
) : KSerializer<T> {
final override val descriptor: SerialDescriptor = buildClassSerialDescriptor(serialName)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class AsyncIterationManager<Item : Any, Result : Any>(public val iterator
}

/**
* An [AsyncIterationManager] specifically for a [Player][com.intuit.player.jvm.core.player.Player]
* An [AsyncIterationManager] specifically for a [Player][com.intuit.playerui.core.player.Player]
* that consumes [String] flows and a results in a [CompletedState].
*/
public typealias FlowManager = AsyncIterationManager<String, CompletedState>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package com.intuit.playerui.core.utils

/**
* Public API marked with this annotation is effectively **internal**, which means
* it should not be used outside of `player.jvm`.
* it should not be used outside of `playerui.core`.
* Signature, semantics, source and binary compatibilities are not guaranteed for this API
* and will be changed without any warnings or migration aids.
*/
Expand Down
4 changes: 2 additions & 2 deletions jvm/j2v8/build.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ deps = {
"//jvm/j2v8:j2v8-macos",
"//jvm/j2v8:j2v8-linux",
"//jvm/j2v8:j2v8-android",
]
],
}

def j2v8_platform(platform):
Expand All @@ -19,7 +19,7 @@ def j2v8_platform(platform):
native.java_library(
name = name,
exports = [":j2v8"] + deps[platform],
tags = ["maven_coordinates=%s:%s:{pom_version}" % ("com.intuit.player", name)],
tags = ["maven_coordinates=%s:%s:{pom_version}" % ("com.intuit.playerui", name)],
visibility = ["//visibility:public"],
)

Expand Down

0 comments on commit 934d05b

Please sign in to comment.