Merge pull request #264 from player-ui/update-iosStageRevertPluginTests

update iOS StageRevertDataPluginTests
player-ui · Jan 8, 2024 · fc98b1c · fc98b1c
2 parents 7c2605c + d4b66a2
commit fc98b1c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -148,7 +148,7 @@ jobs:
           paths:
             - ~/android-tools
 
-      - run: gem install bundler
+      - run: gem install bundler -v 2.4.22
 
       - restore_cache:
           keys:

diff --git a/ios/plugins/StageRevertDataPlugin/Tests/StageRevertDataPluginTests.swift b/ios/plugins/StageRevertDataPlugin/Tests/StageRevertDataPluginTests.swift
@@ -67,12 +67,13 @@ class StageRevertDataPluginTests: XCTestCase {
 
         player.hooks?.viewController.tap { viewController in
             viewController.hooks.view.tap { view in
-                guard view.id == "view-3" else {
-                    (player.state as? InProgressState)?.controllers?.data.set(transaction: ["name": "Test"])
-                    (player.state as? InProgressState)?.controllers?.flow.transition(with: "clear")
-                    return
-                }
                 view.hooks.onUpdate.tap { value in
+                    guard view.id == "view-3" else {
+                        (player.state as? InProgressState)?.controllers?.data.set(transaction: ["name": "Test"])
+                        (player.state as? InProgressState)?.controllers?.flow.transition(with: "clear")
+                        return
+                    }
+
                     let labelValue = value.objectForKeyedSubscript("value").toString()
 
                     XCTAssertEqual(labelValue, "default")
@@ -91,12 +92,13 @@ class StageRevertDataPluginTests: XCTestCase {
 
         player.hooks?.viewController.tap { viewController in
             viewController.hooks.view.tap { view in
-                guard view.id == "view-2" else {
-                    (player.state as? InProgressState)?.controllers?.data.set(transaction: ["name": "Test"])
-                    (player.state as? InProgressState)?.controllers?.flow.transition(with: "commit")
-                    return
-                }
                 view.hooks.onUpdate.tap { value in
+                    guard view.id == "view-2" else {
+                        (player.state as? InProgressState)?.controllers?.data.set(transaction: ["name": "Test"])
+                        (player.state as? InProgressState)?.controllers?.flow.transition(with: "commit")
+                        return
+                    }
+
                     let labelValue = value.objectForKeyedSubscript("value").toString()
 
                     XCTAssertEqual(labelValue, "Test")