-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Transform reference action asset role #169
Comments
Hi @hborawski |
@abhisheksrivastava177 do you have a fix for this issue? |
Working on it now |
Hey @hborawski and @mercillo , a quick question. If we add a ref property in the asset then going ahead all the FRF can specify that if they need an icon or not. For the already implemented back button, we need to make sure they keep showing the icon. Is that what the transform would be used for? Is it to make sure the changes are backward compatible with older back buttons. |
I think previously, we're only checking to see if the value contains metaData: { "role": "back} |
Yes this is to consolidate existing logic, not to add arbitrary icons to the |
The reference react action asset currently renders a
<
icon when the value of the action indicates that the user would go backwards in the flow. Rather than have assets on each platform implement this check, we can move it into the transform and expose a generic property in the action metadata to make the coupling between icon and value looser.Move logic for determining
isBackAction
into the action transform and populate arole
property in themetaData
when applicable.Update the react asset to use
metaData.role
instead of checking the value directly.The text was updated successfully, but these errors were encountered: