Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Transform reference action asset role #169

Closed
hborawski opened this issue Sep 29, 2023 · 7 comments · Fixed by #211
Closed

Core: Transform reference action asset role #169

hborawski opened this issue Sep 29, 2023 · 7 comments · Fixed by #211
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@hborawski
Copy link
Contributor

The reference react action asset currently renders a < icon when the value of the action indicates that the user would go backwards in the flow. Rather than have assets on each platform implement this check, we can move it into the transform and expose a generic property in the action metadata to make the coupling between icon and value looser.

  • Move logic for determining isBackAction into the action transform and populate a role property in the metaData when applicable.

  • Update the react asset to use metaData.role instead of checking the value directly.

@hborawski hborawski added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Sep 29, 2023
@abhisheksrivastava177
Copy link

Hi @hborawski
I am interested in working this feature of player. Can you assign me this and it's references ?

@manansharma18
Copy link
Contributor

manansharma18 commented Oct 18, 2023

@abhisheksrivastava177 do you have a fix for this issue?
Hey @mercillo , I can have a crack at it if @abhisheksrivastava177 does not have a fix

@manansharma18
Copy link
Contributor

Working on it now

@manansharma18
Copy link
Contributor

Hey @hborawski and @mercillo , a quick question. If we add a ref property in the asset then going ahead all the FRF can specify that if they need an icon or not. For the already implemented back button, we need to make sure they keep showing the icon. Is that what the transform would be used for? Is it to make sure the changes are backward compatible with older back buttons.

@mercillo
Copy link
Contributor

I think previously, we're only checking to see if the value contains Prev to see if its a back button.
but if the value contains Prev we can add the metadata in the transform

metaData: { "role": "back}

@hborawski
Copy link
Contributor Author

Yes this is to consolidate existing logic, not to add arbitrary icons to the action asset

@manansharma18
Copy link
Contributor

#211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants