feat/decouple back button #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 82.18% 82.19% +0.01%
==========================================
Files 132 132
Lines 4540 4544 +4
Branches 1117 1118 +1
==========================================
+ Hits 3731 3735 +4
Misses 531 531
Partials 278 278
☔ View full report in Codecov by Sentry. |
hborawski
requested changes
Oct 30, 2023
hborawski
reviewed
Nov 7, 2023
| @@ -27,6 +27,9 @@ export interface ActionAsset<AnyTextAsset extends Asset = Asset> | |||
|
|
|||
| /** Force transition to the next view without checking for validation */ | |||
| skipValidation?: boolean; | |||
|
|
|||
| /** boolean value to decide for the left anchor sign */ | |||
There was a problem hiding this comment.
this docstring should be updated since it is a string now
manansharma18
force-pushed
the
feat/decoupleBackButton
branch
from
af35573 to
af3a8b1
Compare
hborawski
approved these changes
Nov 8, 2023
mercillo
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #169
Change Type (required)
Indicate the type of change your pull request is:
Adds a role property inside the metaData on the action asset. This property is used to decouple the back Icon from the back button.
patchminormajor