Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note to input asset #189

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

aarianasingh
Copy link
Contributor

@aarianasingh aarianasingh commented Oct 18, 2023

Fixes #167
Added a note to the iOS input asset to match web.
Changed the styling of the label on the iOS input asset to more closely match web.
Added padding underneath the info asset to match web (was affecting input transition mock flow)

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Copy link
Contributor

@hborawski hborawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but need to make sure we edit the source for the mocks so its shared for other platforms

ios/packages/demo/Sources/MockFlows.swift Show resolved Hide resolved
@mercillo
Copy link
Contributor

can you pull main for this branch! looks like its still failing for bazel sync

@hborawski hborawski added the skip-release Preserve the current version when merged label Oct 19, 2023
@hborawski hborawski merged commit be77990 into player-ui:main Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest-accepted skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: Render note for Input reference asset
3 participants