Add user info to assetViewModel (Breaking Change) #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborawski
reviewed
Oct 24, 2023
| */ | ||
| public required init(_ data: T) { | ||
| public required init(_ data: T, userInfo: [CodingUserInfoKey: Any]? = nil) { |
There was a problem hiding this comment.
Should this be optional? or default to [:]?
| @@ -75,7 +80,7 @@ open class ControlledAsset<DataType: AssetData, ModelType>: SwiftUIAsset where M | |||
| decoder.logger?.t("Updating model for \(data.id)") | |||
| model.data = data | |||
| } else { | |||
| self.model = ModelType(data) | |||
| self.model = ModelType(data, userInfo: decoder.userInfo) | |||
There was a problem hiding this comment.
Do we need to update the userInfo when we get the model from the cache?
| @@ -15,16 +15,21 @@ open class AssetViewModel<T: AssetData>: ObservableObject { | |||
| /// The decoded data | |||
| @Published public var data: T | |||
|
|
|||
| /// Any contextual information set by the user | |||
| public var userInfo: [CodingUserInfoKey: Any]? | |||
There was a problem hiding this comment.
If we don't need to update this, we can make this let instead of var
There was a problem hiding this comment.
kept it as var in order to set the userinfo when we update the model from cache
added 2 commits
October 25, 2023 11:11
|
not sure why the following tests InfoAssetUITests.testInfoBasic(), InputAssetUITests.testBasicInput(), InputAssetUITests.testInputValidation() keep failing for eyes not finding elements, but passes locally when i run them |
hborawski
approved these changes
Oct 25, 2023
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model can now access the userInfo which can contain information set by the user usually through the plugins (SwiftUIPendingTransactionPlugin, SwiftUIBeaconContextPlugin) which will come later in OSS
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorVersion
Published prerelease version:
0.4.0-next.12Changelog
Release Notes
Android: add note to input ref asset (#192)
Add note field to input reference asset
Export InfoAsset as XLR View (#139)
Export Info Asset as XLR View
sync up to latest (#131)
Sync latest code
Expose utils for expression LSP (#117)
parseExpressionfrom the expression parserstrictflag toparseExpressionthat will (when disabled) attach any parsing errors to the top-level node instead of throwingDeps/bump dependencies (#111)
Dependency upgrades
Sync Latest Player Code (#109)
Syncs to latest version and bumps tapable-ts to latest version.
🚀 Enhancement
🐛 Bug Fix
📝 Documentation
Authors: 15