[iOS] SwiftUIRegistry perf fix #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… performance impacts when Context is held outside managed player
This was referenced Dec 8, 2022
Merged
This was referenced Dec 21, 2022
Merged
This was referenced Jan 25, 2023
This was referenced Oct 26, 2023
Merged
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When holding SwiftUIPlayer context outside of
ManagedPlayer, it also holds the asset registry. Upon each invocation ofapplythe plugins would reregister all their assets, burning cycles in JSCore. This adds an equality check to no-op that exact duplicate registrations, rather than just checking for overriding