Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] ManagedPlayer only unload context on state changes, not when player disappears #137

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

hborawski
Copy link
Contributor

@hborawski hborawski commented Feb 3, 2023

The changes to use JSVirtualMachine by default changed to unload player when it disappeared. Some presentation contexts over ManagedPlayer would trigger onDisappear unintentionally unloading player.

Switch to explicitly unload context on state changes for ManagedPlayer, rather than when SwiftUI disappears

Version

Published prerelease version: 0.4.0-next.7

Changelog

Release Notes

sync up to latest (#131)

Sync latest code

Expose utils for expression LSP (#117)

  • Expose parseExpression from the expression parser
  • Adds a strict flag to parseExpression that will (when disabled) attach any parsing errors to the top-level node instead of throwing

Deps/bump dependencies (#111)

Dependency upgrades

Sync Latest Player Code (#109)

Syncs to latest version and bumps tapable-ts to latest version.


🚀 Enhancement

🐛 Bug Fix

Authors: 7

@hborawski hborawski added the patch Increment the patch version when merged label Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 82.26% // Head: 82.26% // No change to project coverage 👍

Coverage data is based on head (aa96675) compared to base (380eb6b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files         118      118           
  Lines        4117     4117           
  Branches     1031     1031           
=======================================
  Hits         3387     3387           
  Misses        471      471           
  Partials      259      259           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant