Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin bazel version to 5.4.0 #112

Merged
merged 1 commit into from
Dec 19, 2022
Merged

pin bazel version to 5.4.0 #112

merged 1 commit into from
Dec 19, 2022

Conversation

sugarmanz
Copy link
Member

Bazel 6.0.0 was released today:

https://github.com/bazelbuild/bazel/releases/tag/6.0.0

Since this repo isn't already pinned to a 5.x version of Bazel, Bazelisk will automatically try latest, which won't work with our workspace. This will ensure that Bazelisk will use 5.4.0 of Bazel until we're ready to upgrade.

@sugarmanz sugarmanz added the skip-release Preserve the current version when merged label Dec 19, 2022
@sugarmanz sugarmanz requested a review from adierkens as a code owner December 19, 2022 20:15
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 78.57% // Head: 79.07% // Increases project coverage by +0.50% 🎉

Coverage data is based on head (481c720) compared to base (b51603b).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   78.57%   79.07%   +0.50%     
==========================================
  Files         130      132       +2     
  Lines        4504     4655     +151     
  Branches     1114     1164      +50     
==========================================
+ Hits         3539     3681     +142     
  Misses        688      688              
- Partials      277      286       +9     
Impacted Files Coverage Δ
core/player/src/binding/resolver.ts 80.95% <ø> (ø)
core/player/src/data/model.ts 87.80% <ø> (ø)
core/player/src/expressions/evaluator.ts 80.12% <ø> (ø)
core/player/src/expressions/types.ts 100.00% <ø> (ø)
plugins/auto-scroll/react/src/hooks.tsx 100.00% <ø> (ø)
core/player/src/expressions/utils.ts 46.15% <47.36%> (+46.15%) ⬆️
core/player/src/expressions/parser.ts 79.75% <86.66%> (+0.19%) ⬆️
plugins/check-path/core/src/index.ts 92.95% <87.50%> (+0.92%) ⬆️
core/player/src/player.ts 79.10% <88.88%> (+0.80%) ⬆️
core/player/src/controllers/data.ts 97.36% <100.00%> (+0.03%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants