Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in Language Changes #85

Merged
merged 19 commits into from
Jan 27, 2023
Merged

Bring in Language Changes #85

merged 19 commits into from
Jan 27, 2023

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Oct 14, 2022

This PR does the following:

  • Removes packages that are now in the player tools repository
  • Generates XLRs for @player-ui/types, @player-ui/reference-assets-plugin, @player-ui/common-expressions-plugin and @player-ui/common-types-plugin
  • Adds some basic docs for XLRs

Release Notes

Removes migrated packages, XLR generation, XLR docs

📦 Published PR as canary version: 0.4.0--canary.85.4696

Try this version out locally by upgrading relevant packages to 0.4.0--canary.85.4696

Version

Published prerelease version: 0.4.0-next.6

Changelog

Release Notes

sync up to latest (#131)

Sync latest code

Expose utils for expression LSP (#117)

  • Expose parseExpression from the expression parser
  • Adds a strict flag to parseExpression that will (when disabled) attach any parsing errors to the top-level node instead of throwing

Deps/bump dependencies (#111)

Dependency upgrades

Sync Latest Player Code (#109)

Syncs to latest version and bumps tapable-ts to latest version.


🚀 Enhancement

🐛 Bug Fix

Authors: 7

@KetanReddy KetanReddy self-assigned this Oct 14, 2022
@KetanReddy KetanReddy added the minor Increment the minor version when merged label Oct 14, 2022
@KetanReddy KetanReddy force-pushed the refactor/move-language branch from e3eb74b to fe95abf Compare October 18, 2022 18:35
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 79.07% // Head: 82.53% // Increases project coverage by +3.45% 🎉

Coverage data is based on head (5f74b2c) compared to base (99cb3dd).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   79.07%   82.53%   +3.45%     
==========================================
  Files         132      117      -15     
  Lines        4655     4077     -578     
  Branches     1164     1019     -145     
==========================================
- Hits         3681     3365     -316     
+ Misses        688      455     -233     
+ Partials      286      257      -29     
Impacted Files Coverage Δ
core/player/src/expressions/types.ts 100.00% <ø> (ø)
core/player/src/player.ts 79.10% <ø> (ø)
...s/common-expressions/core/src/expressions/index.ts 93.33% <ø> (ø)
plugins/common-expressions/core/src/index.ts 100.00% <ø> (ø)
plugins/common-types/core/src/index.ts 100.00% <ø> (ø)
plugins/reference-assets/components/src/index.tsx 100.00% <ø> (ø)
plugins/reference-assets/react/src/plugin.tsx 81.81% <ø> (ø)
core/player/src/expressions/parser.ts 80.17% <80.00%> (+0.41%) ⬆️
core/player/src/expressions/evaluator.ts 80.12% <100.00%> (ø)
core/player/src/view/parser/index.ts 79.26% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KetanReddy KetanReddy changed the title [WIP] Bring in Language Changes Bring in Language Changes Oct 18, 2022
@KetanReddy KetanReddy marked this pull request as ready for review October 18, 2022 19:55
@KetanReddy KetanReddy requested a review from adierkens as a code owner October 18, 2022 19:55
@KetanReddy
Copy link
Member Author

Applitools failure is a non-issue

@@ -6,20 +6,16 @@

# Android/JVM

jvm/ @sugarmanz @Brocollie08
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangential to the main purpose of the PR but I noticed in #95 I was tagged as a code owner because there were changes in the core directory under the jvm folder. These paths should be from the root, not relative.

@KetanReddy
Copy link
Member Author

/canary

@KetanReddy KetanReddy marked this pull request as draft January 23, 2023 02:18
@KetanReddy KetanReddy marked this pull request as ready for review January 27, 2023 00:17
@KetanReddy
Copy link
Member Author

/canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant