Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Up To Latest #193

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Oct 18, 2023

📦 Published PR as canary version: 0.3.1--canary.193.5900

Try this version out locally by upgrading relevant packages to 0.3.1--canary.193.5900

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Oct 18, 2023
@KetanReddy KetanReddy self-assigned this Oct 18, 2023
@KetanReddy
Copy link
Member Author

/canary

3 similar comments
@KetanReddy
Copy link
Member Author

/canary

@KetanReddy
Copy link
Member Author

/canary

@hborawski
Copy link
Contributor

/canary

@KetanReddy KetanReddy marked this pull request as ready for review October 25, 2023 15:54
@KetanReddy KetanReddy changed the title [WIP] Sync Up To Latest Sync Up To Latest Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (766bb5a) 82.26% compared to head (dbf2921) 82.23%.
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   82.26%   82.23%   -0.04%     
==========================================
  Files         118      129      +11     
  Lines        4117     4519     +402     
  Branches     1031     1114      +83     
==========================================
+ Hits         3387     3716     +329     
- Misses        471      526      +55     
- Partials      259      277      +18     
Files Coverage Δ
core/player/src/binding-grammar/custom/index.ts 94.77% <100.00%> (ø)
core/player/src/binding/binding.ts 100.00% <ø> (ø)
core/player/src/binding/index.ts 93.44% <100.00%> (+0.22%) ⬆️
core/player/src/binding/resolver.ts 80.95% <ø> (ø)
core/player/src/controllers/flow/controller.ts 100.00% <100.00%> (ø)
core/player/src/controllers/flow/flow.ts 100.00% <100.00%> (ø)
core/player/src/controllers/view/controller.ts 95.65% <100.00%> (+0.91%) ⬆️
core/player/src/data/noop-model.ts 33.33% <ø> (ø)
core/player/src/expressions/evaluator.ts 81.04% <100.00%> (+0.91%) ⬆️
core/player/src/expressions/types.ts 100.00% <100.00%> (ø)
... and 47 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy merged commit d04ee7c into main Oct 25, 2023
14 of 15 checks passed
@KetanReddy KetanReddy deleted the sync/167e780a5a4576e4e0474dcce1548a053fa0fa87 branch October 25, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants