Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: add Support For Segmented Assets #191

Merged
merged 5 commits into from
Oct 20, 2023

Conversation

manansharma18
Copy link
Contributor

@manansharma18 manansharma18 commented Oct 18, 2023

Change Type (required)

Indicate the type of change your pull request is:
This PR adds a transform for the Info asset. The transform adds a property called segmentedAssets to the asset. SegmentedAssets is a collection of next and prev actions and extracting the logic out of the react component makes it useable for ios and android.
Further support would be required by android and ios to use segmentedAssets

  • patch
  • minor
  • major
    Screenshot 2023-10-20 at 9 08 06 AM

@manansharma18 manansharma18 changed the title add Support For Segmented Assets Core: add Support For Segmented Assets Oct 18, 2023
@mercillo mercillo enabled auto-merge October 20, 2023 15:21
@mercillo mercillo disabled auto-merge October 20, 2023 15:21
@mercillo mercillo self-requested a review October 20, 2023 15:44
@mercillo mercillo removed the request for review from adierkens October 20, 2023 15:52
@KetanReddy KetanReddy enabled auto-merge October 20, 2023 16:24
@KetanReddy KetanReddy disabled auto-merge October 20, 2023 16:24
@mercillo mercillo merged commit e191d02 into player-ui:main Oct 20, 2023
1 check passed
@hborawski hborawski added skip-release Preserve the current version when merged patch Increment the patch version when merged labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest-accepted patch Increment the patch version when merged skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants