Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPod publishing #20

Merged
merged 26 commits into from
Jul 27, 2022
Merged

CocoaPod publishing #20

merged 26 commits into from
Jul 27, 2022

Conversation

hborawski
Copy link
Contributor

@hborawski hborawski commented Jul 21, 2022

Push pod zips to GH release
push podspec to cocoapods trunk

since pod trunk push uses pod spec lint under the hood, with no way to skip, i have to fake the spec lint by pointing the podspec to the circle artifact, so itll verify and push, and then podspec will normally point to the GH release

@hborawski hborawski requested a review from adierkens as a code owner July 21, 2022 22:53
@hborawski hborawski changed the title WIP: set up CocoaPod publishing CocoaPod publishing Jul 26, 2022
BUILD.bazel Outdated
Comment on lines 83 to 84
# because jenkins runs as root
"--allow-root"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still the case for circle?

@@ -4,6 +4,7 @@ set -eo pipefail # exit immediately if any command fails.

echo STABLE_GIT_COMMIT $(git rev-parse HEAD)
echo STABLE_VERSION $(cat VERSION)
echo VERSION $(cat VERSION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why VERSION in addition to STABLE_VERSION?

@hborawski hborawski merged commit 2889d7f into main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants