Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

179/AndroidContributionGuide #200

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

mercillo
Copy link
Contributor

Documentation Updates for android contribution.

Added troubleshooting for common issues when getting started.

@mercillo mercillo marked this pull request as ready for review October 24, 2023 17:53
@mercillo mercillo changed the title redone from main, bazel sync was stuck 179/AndroidContributionGuide Oct 24, 2023
Copy link
Contributor

@hborawski hborawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if the bundle install step is correct



### 2. If you are seeing Errors around babel
Make sure you have done a `bundle install`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right? why does the iOS ruby dependencies matter for babel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was when they got an error of
could not find dependency @babel/helper-string-parser of @babel.plugin-transform-react-jsx/noode_modules/@babel/types
Error: Analysis of target '//android/demo:demo' failed; build aborted.

they ended up not doing a bundle install haha, let me add this error to specify which error

@mercillo mercillo added the documentation Changes only affect the documentation label Nov 1, 2023
@mercillo mercillo added the skip-release Preserve the current version when merged label Nov 3, 2023
@mercillo mercillo merged commit 1a8b1dd into player-ui:main Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants