fix for iOS: Render label for collection reference asset #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hborawski Can you please review? |
hborawski
added
skip-release
|
you may need to pull in the main branch as your builds are failing |
hborawski
requested changes
Oct 27, 2023
| @@ -31,6 +31,7 @@ struct CollectionAssetView: View { | |||
| @ViewBuilder | |||
| var body: some View { | |||
| VStack { | |||
| model.data.label?.asset?.view.font(.label) | |||
There was a problem hiding this comment.
This has a compilation error as CollectionData has no label member. You will need to update the data struct to reflect what needs to be decoded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #159
Change Type (required)
Indicate the type of change your pull request is:
patchminormajor