Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocks for plugins #206

Merged
merged 44 commits into from
Nov 21, 2023
Merged

Mocks for plugins #206

merged 44 commits into from
Nov 21, 2023

Conversation

mercillo
Copy link
Contributor

@mercillo mercillo commented Oct 25, 2023

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Version

Published prerelease version: 0.4.5-next.0

Changelog

🐛 Bug Fix

🏠 Internal

Authors: 8

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c92e13f) 82.21% compared to head (ffa1afd) 82.16%.
Report is 38 commits behind head on main.

❗ Current head ffa1afd differs from pull request most recent head f630cce. Consider uploading reports for the commit f630cce to get more accurate results

Files Patch % Lines
core/player/src/expressions/evaluator.ts 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   82.21%   82.16%   -0.06%     
==========================================
  Files         132      132              
  Lines        4544     4546       +2     
  Branches     1118     1119       +1     
==========================================
- Hits         3736     3735       -1     
- Misses        531      534       +3     
  Partials      277      277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mercillo mercillo marked this pull request as ready for review October 26, 2023 20:07
@mercillo mercillo requested a review from adierkens as a code owner October 26, 2023 20:07
@mercillo mercillo requested a review from KetanReddy as a code owner November 3, 2023 15:09
hborawski and others added 3 commits November 3, 2023 08:29
* merge trunk and fork workflows

* reference correct test

* hyphen

* separate deps for trunk and fork jobs

* add names to jobs called twice

* filters on jobs called twice

* re-order params

* fix config.yml

---------

Co-authored-by: brocollie08 <sentony03@gmail.com>
@mercillo mercillo marked this pull request as draft November 8, 2023 22:18
@mercillo mercillo marked this pull request as ready for review November 9, 2023 18:29
jvm/testutils/deps.bzl Outdated Show resolved Hide resolved
plugins/external-action/mocks/index.ts Outdated Show resolved Hide resolved
plugins/reference-assets/android/build.bzl Outdated Show resolved Hide resolved
plugins/reference-assets/android/deps.bzl Outdated Show resolved Hide resolved
jvm/core/deps.bzl Outdated Show resolved Hide resolved
index.bzl Show resolved Hide resolved
@mercillo mercillo merged commit b06114c into player-ui:main Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants