Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins core and react doc addition #281

Closed
wants to merge 15 commits into from

Conversation

lexfm
Copy link
Contributor

@lexfm lexfm commented Jan 29, 2024

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

@lexfm lexfm changed the title plugin core doc addition plugins core and react doc addition Jan 30, 2024
@lexfm lexfm added documentation Changes only affect the documentation skip-release Preserve the current version when merged labels Jan 30, 2024
@lexfm lexfm marked this pull request as ready for review January 30, 2024 19:45
@KetanReddy
Copy link
Member

I think one thing that is missing is that "next step" of documentatio. Demonstrating how to create a plugin is good but covering what you can actually do would be better. Doing it inline might get a bit long so maybe that becomes a different section? One thing we do in some other parts of the docs is take something already in the codebase and explain how/why its built the way it is.

@lexfm lexfm marked this pull request as draft January 31, 2024 18:03
@lexfm lexfm marked this pull request as ready for review February 2, 2024 21:57
@lexfm
Copy link
Contributor Author

lexfm commented Feb 6, 2024

Closing due to forked branch not completing checks, moved changes to this PR instead.

@lexfm lexfm closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants