-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse multi node switch fixv1 #347
Merged
KetanReddy
merged 6 commits into
player-ui:main
from
mercillo:parseMultiNodeSwitchFixv1
Apr 25, 2024
Merged
Parse multi node switch fixv1 #347
KetanReddy
merged 6 commits into
player-ui:main
from
mercillo:parseMultiNodeSwitchFixv1
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborawski
reviewed
Apr 24, 2024
KetanReddy
reviewed
Apr 24, 2024
hborawski
approved these changes
Apr 24, 2024
KetanReddy
approved these changes
Apr 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 81.90% 81.93% +0.02%
==========================================
Files 133 133
Lines 4619 4621 +2
Branches 1142 1144 +2
==========================================
+ Hits 3783 3786 +3
Misses 555 555
+ Partials 281 280 -1 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multinodes contained switches; the switch would not evaluate correctly.
when staticSwitches get evaluated to false; the asset should not live in the AST, however there was a bug that caused staticSwitches not to get read as a switch when they were inside of multinodes.
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
Does your PR have any documentation updates?
Version
Published prerelease version:
0.7.3-next.2
Changelog
🐛 Bug Fix
PlayerFragment
state updates #343 (@sugarmanz)📝 Documentation
Authors: 8