enhance error state deserialization & stacktrace logging in player view model #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugarmanz
requested review from
KetanReddy,
adierkens and
brocollie08
as code owners
brocollie08
reviewed
Aug 4, 2022
| ?: PlayerException(node.getString("error") ?: "unable to determine error") | ||
| override val error: PlayerException get() = when (val rawError = node["error"]) { | ||
| is PlayerException -> rawError | ||
| is Exception -> PlayerException(rawError.message ?: "", rawError) |
There was a problem hiding this comment.
out of curiosity, when do these two cases come into play
There was a problem hiding this comment.
It's more for completeness than anything. I actually think that Graal works this way and is able to spit up the original exception, which may or may not be a PlayerException, but that could be wrong. If Node internals change in the future with some introspection for Node children that are error-like and try to deserialize automatically, this will account for that.
brocollie08
approved these changes
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
=======================================
Coverage 77.32% 77.32%
=======================================
Files 130 130
Lines 4427 4427
Branches 1093 1093
=======================================
Hits 3423 3423
Misses 727 727
Partials 277 277 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Aug 8, 2022
This was referenced Aug 17, 2022
Merged
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
Published prerelease version:
0.1.1-next.0Changelog
🐛 Bug Fix
Authors: 1