-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS: Expose builldBeacon and cancelBeacon hooks inside of BaseBeaconPlugin and make BeaconPlugin open class #536
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
==========================================
- Coverage 89.57% 89.54% -0.04%
==========================================
Files 331 331
Lines 19718 19830 +112
Branches 1949 1949
==========================================
+ Hits 17663 17757 +94
- Misses 2041 2059 +18
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
/canary |
@@ -18,20 +18,14 @@ import PlayerUIBaseBeaconPlugin | |||
/** | |||
Plugin used by `SwiftUIPlayer` for beaconing in a uniform format between platforms | |||
*/ | |||
public class BeaconPlugin<BeaconStruct: Decodable>: BaseBeaconPlugin<BeaconStruct>, NativePlugin { | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like comments were removed by accident?
Change Type (required)
Indicate the type of change your pull request is:
iOS: Expose builldBeacon and cancelBeacon hooks inside of BaseBeaconPlugin and make BeaconPlugin open class
patch
minor
major
Does your PR have any documentation updates?
📦 Published PR as canary version:
0.9.2--canary.536.18200
Try this version out locally by upgrading relevant packages to 0.9.2--canary.536.18200
Version
Published prerelease version:
0.10.0-next.6
Changelog
Release Notes
Remove unneeded dependency on
pubsub-js
(#547)Remove dead dependencies
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
Does your PR have any documentation updates?
Minor Docs Fixes (#538)
next
subdomain searching against and redirecting tolatest
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
Does your PR have any documentation updates?
More Doc Fixes (#532)
latest
andnext
pagesChange Type (required)
Indicate the type of change your pull request is:
patch
minor
major
Does your PR have any documentation updates?
Fix docs build visibility (#531)
Fix visibility of docs build
ios: enhance tapable logger to handle variadic args from the JS log (#524)
Prefixing message with the format
[Player] [\(logLevel)]:
moved out of the Tapable logger and moved to PrintLoggerPlugin. Any consumers using their own LoggerPlugin will need to append the logLevel if they want to print itBefore
After
Breaking Changes
Any usage of the
player.logger.hooks
taps will have breaking changes in the callback because the calls have been changed to provide a[Any]
type instead ofString
so it can be returned in the form of messages instead of a single message. Unless nothing is done in the callback to access the value but just to print it, there should be breaking changesExample:
🚀 Enhancement
🐛 Bug Fix
pubsub-js
#547 (@KetanReddy)🏠 Internal
📝 Documentation
Authors: 7