Update to explicitly call out the default value for dataPath #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for dataPath The docs used the word "enable" that made us think that if a `dataPath` isnt provided, the constants will not be overridable through content. However, looking at the code thats not true https://github.com/player-ui/player/blob/7e2c1a691ea8e0aae1f2c412d145dcb4749d7164/plugins/shared-constants/core/src/index.ts#L45
KetanReddy
reviewed
Feb 3, 2025
docs/site/src/content/docs/plugins/multiplatform/shared-constants.mdx
Outdated
Show resolved
Hide resolved
KetanReddy
previously approved these changes
Feb 3, 2025
KetanReddy
added
patch
|
Hey @A1shK, approved the PR in principle. Can you write release notes for though? |
…nts.mdx Co-authored-by: Ketan Reddy <KetanReddy@users.noreply.github.com>
KetanReddy
approved these changes
Feb 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 89.84% 89.76% -0.09%
==========================================
Files 331 331
Lines 19840 19840
Branches 1949 1949
==========================================
- Hits 17825 17809 -16
- Misses 2001 2017 +16
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs used the word "enable" that made us think that if a
dataPathisnt provided, the constants will not be overridable through content. However, looking at the code thats not true.Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
Release Notes
Updated docs for Shared Constants Plugin to highlight the default dataPath used for overriding values