Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] add registerPlugin(_:) to HeadlessPlayer API #79

Merged
merged 1 commit into from
Aug 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ios/packages/core/Sources/Player/HeadlessPlayer.swift
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,15 @@ public extension HeadlessPlayer {
]])
}

/// Registers a plugin with player after instantiation
/// Primarily for plugins to be able to add other plugins to player
/// - Parameter plugin: The plugin to register
func registerPlugin<P: JSBasePlugin>(_ plugin: P) {
assert(jsPlayerReference != nil, "Cannot register plugins before setuPlayer(context:plugins:) is called")
plugin.context = jsPlayerReference?.context
jsPlayerReference?.invokeMethod("registerPlugin", withArguments: [plugin.pluginRef as Any])
}

/**
Starts Player for the given flow
- parameters:
Expand Down
19 changes: 19 additions & 0 deletions ios/packages/core/Tests/HeadlessPlayerTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,25 @@ class HeadlessPlayerTests: XCTestCase {
XCTAssertNotNil(state.controllers)
}

func testRegisterPlugin() {
class RegisterMePlugin: JSBasePlugin {
convenience init() {
self.init(fileName: "", pluginName: "")
}

override func setup(context: JSContext) {}
}
let player = HeadlessPlayerImpl(plugins: [])

player.start(flow: FlowData.COUNTER) { _ in }

let plugin = RegisterMePlugin()

player.registerPlugin(plugin)

XCTAssertNotNil(plugin.context)
}

func testEmptyFlowObject() {
let player = HeadlessPlayerImpl(plugins: [])
player.start(flow: "{}") { (result) in
Expand Down