Add rule for using the Player CLI to compile XLRs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure is just due to a missing tag. |
adierkens
reviewed
Oct 26, 2022
Comment on lines
+69
to
+72
| JSModuleInfo( | ||
| direct_sources = output_depset, | ||
| sources = output_depset, | ||
| ), |
There was a problem hiding this comment.
Does this need a JSModuleInfo if this isn't an actual JS package?
There was a problem hiding this comment.
I wasn't 100% sure since it does produce a js file that could be imported in other down-stream packages.
adierkens
approved these changes
Oct 26, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xlr_compileto use the Player CLI to compile XLRs for a package.js_library_pipelinesince its not applicable in all use cases.