Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade bazel distribution to branch that includes curl fix #25

Merged
merged 2 commits into from
Dec 13, 2022
Merged

upgrade bazel distribution to branch that includes curl fix #25

merged 2 commits into from
Dec 13, 2022

Conversation

sugarmanz
Copy link
Member

No description provided.

@sugarmanz sugarmanz added the patch Increment the patch version when merged label Dec 12, 2022
@sugarmanz sugarmanz enabled auto-merge (squash) December 12, 2022 22:22
@KetanReddy
Copy link
Member

Any idea why curl is writing messages to err?

@sugarmanz
Copy link
Member Author

https://github.com/vaticle/bazel-distribution/blob/master/maven/templates/deploy.py#L44

This writes to /dev/stderr, but that no longer (or never did) work properly for our internal Jenkins servers. Something about how /dev/stderr can only be opened by a proper terminal and how some build configurations aren't full terminals. Writing to /dev/null works instead.

sugarmanz
sugarmanz commented Dec 13, 2022
View reviewed changes
player/bundle/bundle.bzl
"--mode %s" % MODES[mode_shorthand],
bundle_entry,
bundle_entry if bundle_entry else "./$(RULEDIR)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KetanReddy I changed the approach a little bit from your webpack PR: #24

Essentially, I default to the prior value, ./$(RULEDIR), to be compatible with existing usages. I also swapped the param positions to prevent it from breaking existing integrations that passed a bundle_name as an unamed param.

@sugarmanz sugarmanz merged commit 52de3fc into main Dec 13, 2022
@sugarmanz sugarmanz deleted the distribution-upgrade branch December 13, 2022 01:14
@intuit-svc
Copy link

🚀 PR was released in v0.10.2 🚀

@intuit-svc intuit-svc added the released This issue/pull request has been released. label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KetanReddy KetanReddy KetanReddy approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sugarmanz @KetanReddy @intuit-svc