Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS publishing rule updates #51

Merged
merged 8 commits into from
Jul 18, 2024
Merged

iOS publishing rule updates #51

merged 8 commits into from
Jul 18, 2024

Conversation

hborawski
Copy link
Contributor

@hborawski hborawski commented Jul 1, 2024 •
edited
Loading

  • Added ios_publish rule for publishing a built zip to SPM + CocoaPods
  • Added spm_publish rule for dumping + tagging zip into another repo

the ios_publish rule will put stable releases (versions that dont have any semver metadata) onto one branch, and prerelease/canary versions will update a branch for the semver version its targetting.

so 0.7.4--canary.391.13829 would tag commits on branch 0.7.4
so 0.7.4-next.0 would tag commits on branch 0.7.4
and 0.7.4 would tag commits on branch main

after a stable release, the corresponding branch with that version would no longer be needed and would be simple to delete as well as any prerelease/canary tags prefixed with the new version for player-ui/player#407

@hborawski hborawski added the patch Increment the patch version when merged label Jul 1, 2024
@hborawski hborawski requested a review from nancywu1 July 1, 2024 21:58
Base automatically changed from bazel-6 to main July 12, 2024 04:25
@hborawski hborawski marked this pull request as ready for review July 17, 2024 16:01
@hborawski hborawski mentioned this pull request Jul 17, 2024
Open
@hborawski hborawski merged commit cbd378f into main Jul 18, 2024
2 checks passed
@hborawski hborawski deleted the ios_publishing branch July 18, 2024 16:32
@intuit-svc
Copy link

🚀 PR was released in v1.0.1 🚀

@intuit-svc intuit-svc added the released This issue/pull request has been released. label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nancywu1 nancywu1 nancywu1 approved these changes

@mercillo mercillo mercillo approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hborawski @intuit-svc @mercillo @nancywu1