Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error Thrown when Indexing Long Lists #35

Closed
KetanReddy opened this issue Jan 30, 2023 · 0 comments · Fixed by #36
Closed

Error Thrown when Indexing Long Lists #35

KetanReddy opened this issue Jan 30, 2023 · 0 comments · Fixed by #36
Labels
bug Something isn't working good first issue Good for newcomers patch Increment the patch version when merged XLR Related to XLR Functionality

Comments

@KetanReddy
Copy link
Member

When using typeof to enumerate a long list of consts to get a set of values, if the list is long enough, typescript will truncate the the values we use to convert to XLR and we get an error thrown. It seems like our current approach of pulling that info from the Type object might need to be more robust. This branch has a failing test that can be used to validate the new approach works.

image
@KetanReddy KetanReddy added bug Something isn't working good first issue Good for newcomers patch Increment the patch version when merged XLR Related to XLR Functionality labels Jan 30, 2023
@KetanReddy KetanReddy linked a pull request Jan 30, 2023 that will close this issue
[WIP] Drag and Drop Editing and Sample Editor #25
Draft
@KetanReddy KetanReddy mentioned this issue Jan 30, 2023
Merged
@KetanReddy KetanReddy removed a link to a pull request Jan 31, 2023
[WIP] Drag and Drop Editing and Sample Editor #25
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers patch Increment the patch version when merged XLR Related to XLR Functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/long lists player-ui/tools
1 participant
@KetanReddy