Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create oclif manifest #168

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Don't create oclif manifest #168

merged 1 commit into from
Sep 26, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Sep 20, 2024

Closes #167. A manifest is not technically required so instead of figuring out how to stamp it correctly we can just remove it from the generation pipeline.

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Release Notes

Fixes issue with oclif manifest not being stamped with the right version leading to console errors

Version

Published prerelease version: 0.8.1-next.0

Changelog

Release Notes

Don't create oclif manifest (#168)

Fixes issue with oclif manifest not being stamped with the right version leading to console errors


🐛 Bug Fix

Authors: 1

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Sep 20, 2024
@KetanReddy KetanReddy requested a review from a team September 20, 2024 19:38
@KetanReddy KetanReddy self-assigned this Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (260892c) to head (4a56f76).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   75.35%   75.35%           
=======================================
  Files          87       87           
  Lines       13033    13033           
  Branches     1225     1225           
=======================================
  Hits         9821     9821           
  Misses       3212     3212           
Flag Coverage Δ
75.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy merged commit 2aa19f0 into main Sep 26, 2024
8 checks passed
@KetanReddy KetanReddy deleted the bugfix/oclif-manifest branch September 26, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oclif Manifest Getting Wrong Version
2 participants