Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to LSPAssetsPlugin to load from TSManifest via module import #171

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Sep 27, 2024

Closes #98

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Release Notes

Allow for loading XLRs to LSP via module imports. Add explicit (optional for now) toggle for distinguishing between module and manifest loading.

Version

Published prerelease version: 0.9.0-next.1

Changelog

Release Notes

Add options to LSPAssetsPlugin to load from TSManifest via module import (#171)

Allow for loading XLRs to LSP via module imports. Add explicit (optional for now) toggle for distinguishing between module and manifest loading.


🚀 Enhancement

🐛 Bug Fix

  • Add options to LSPAssetsPlugin to load from TSManifest via module import #171 (@KetanReddy)

Authors: 2

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Sep 27, 2024
@KetanReddy KetanReddy requested review from rafbcampos and a team September 27, 2024 21:26
@KetanReddy KetanReddy self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.77%. Comparing base (260892c) to head (e8ffabd).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   75.35%   72.77%   -2.58%     
==========================================
  Files          87       87              
  Lines       13033    13033              
  Branches     1225     1224       -1     
==========================================
- Hits         9821     9485     -336     
- Misses       3212     3528     +316     
- Partials        0       20      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hborawski
hborawski previously approved these changes Oct 2, 2024
@KetanReddy KetanReddy force-pushed the feature/cli-assets-plugin-for-module branch from 7c34abf to e8ffabd Compare October 3, 2024 16:08
@KetanReddy KetanReddy merged commit f82434d into main Oct 9, 2024
7 of 8 checks passed
@KetanReddy KetanReddy deleted the feature/cli-assets-plugin-for-module branch October 9, 2024 21:05
@intuit-svc intuit-svc mentioned this pull request Dec 3, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow LSPAssetsPlugin to Load Assets from Module
3 participants