Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable workflow for Antora #40

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Reusable workflow for Antora #40

merged 1 commit into from
Sep 30, 2022

Conversation

ihostage
Copy link
Member

No description provided.

${{ runner.os }}-node-

- name: Install Antora and extensions
run: npm i -D -E --quiet --no-progress @antora/cli@3.1.1 @antora/site-generator@3.1.1 @antora/lunr-extension@1.0.0-alpha.8
Copy link
Member Author

@ihostage ihostage Sep 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Antora version doesn't variable because we must use the same version for all modules. We need a one place for bump this version.

@ihostage ihostage requested a review from mkurz September 30, 2022 15:00
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with Antora, so you will use it for play-soap now? It's fine for me. (This is just a workflow, so if something goes wrong we Antora we can just revert his pr, does not really hurt anyone)

@ihostage
Copy link
Member Author

Yes, I want to start from Play SOAP, but who knows how this story will end 😂

@ihostage ihostage merged commit d90eeca into main Sep 30, 2022
@ihostage ihostage deleted the antora branch September 30, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants