-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to sbt 1.0 #32
Conversation
Did a first pass. The bulk of the changes pending is on: omnidoc/project/OmnidocBuild.scala Lines 195 to 204 in 74c95cc
Causing the errors:
The other pending change is moving all the code from |
just remember not to use coursier
This is shaping up well. Currently, I only get small differences on the generated HTML of the javadocs:
The main cause of code changes was modifications on the visibility and behavior of Ivy dependency resolution. Omnidoc downloads |
I've done a review of the diff's and it's all differences in sorting the elements on the HTML lists. I think the output is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nicely done.
Wouldn't have done it without your help. :-) |
I dunno, your follow-up diff is some impressive work. |
Fixes #19 Upgrades the build to sbt 1.0
* Publish documentation for Scala 2.12 instead of 2.11 (#23) * Update interplay to version 1.3.15 (#22) * Add travis configuration to test publishing the library (#27) * Add travis configuration to test publishing the library * Remove scala 2.13.0-M5 * Remove anorm from published docs (#30) * Upgrade to sbt 1.0 (#32) Fixes #19 Upgrades the build to sbt 1.0 * Update play-functional, play-json to 2.7.2 (#34) Updates * com.typesafe.play:play-functional * com.typesafe.play:play-json from 2.7.1 to 2.7.2. I'll automatically update this PR to resolve conflicts as long as you don't change it yourself. If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below. Have a nice day! <details> <summary>Ignore future updates</summary> Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [{ groupId = "com.typesafe.play" }] ``` </details> * Update interplay to 2.0.5 (#33) * Play 2.7.1 (#36) * Only use supported scala versions (#39) * Update play-functional, play-json to 2.7.3 (#40) * Play 2.7.2 (#41) * fixed filters-helpers
Fixes #19
Upgrades the build to sbt 1.0