-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a flag to disable file hash check #111
Provide a flag to disable file hash check #111
Conversation
https://github.com/gmethvin/directory-watcher does file hash check by default to deduplicate change events. But that can increase the startup time on large code base.
Hi @anton-fomin, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Co-authored-by: João Ferreira <jtjeferreira@gmail.com>
@raboof could you have a look? |
@mkurz since you are actively working on play issues and PRs, do you think you could help move this forward? |
Do I understand correctly that the file hash check mechanism is only relevant when running an app with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a mistake with the default.
I think so, however this PR does not change anything, it will just allow play or users to change it without making a copy of In our work project changing this saved around 5s when starting the app. See also a flamegraph where we saved around 5s: The purple is from searching "watch" which you can see is now reduced... |
Co-authored-by: João Ferreira <jtjeferreira@gmail.com>
@jtjeferreira Curious, how large is your project? How many files? Sub-projects? |
around 6000 scala files, 60 sub projects |
https://github.com/gmethvin/directory-watcher does file hash check by default
to deduplicate change events. But that can increase the startup time on
large code base.
Fixes #110